Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CERTZ-1.1/1.2-gNSI Client Certificate Tests #2488

Closed
wants to merge 0 commits into from
Closed

CERTZ-1.1/1.2-gNSI Client Certificate Tests #2488

wants to merge 0 commits into from
+0 −0

Conversation

priyacj
Copy link

@priyacj priyacj commented Dec 14, 2023 •
edited
Loading

Initial Commit of CERTZ-1.1 and CERTZ-1.2
Resolves #1990 and #1991

@priyacj priyacj requested review from a team as code owners December 14, 2023 08:04
@google-cla Google CLA
Copy link

google-cla bot commented Dec 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@OpenConfigBot
Copy link

OpenConfigBot commented Dec 14, 2023 •
edited
Loading

Pull Request Functional Test Report for #2488 / 3fa63f1

No tests identified for validation.

Help

@coveralls
Copy link

coveralls commented Dec 14, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 12418101447

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%
Totals Coverage Status
Change from base Build 12418008563: 0.0%
Covered Lines: 1983
Relevant Lines: 3588
💛 - Coveralls

@mohanasm mohanasm added juniper-pr new-requirement-pr The PR introduces a new test scenario/requirement. labels Dec 14, 2023
@priyacj priyacj changed the title CERTZ-1.1-gNSI Client Certificate Tests CERTZ-1.1/1.2-gNSI Client Certificate Tests Dec 19, 2023
@priyacj priyacj mentioned this pull request Dec 19, 2023
Open
sezhang2
sezhang2 previously approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@sezhang2 sezhang2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add one more reviewer who is familiar with gNSI test requirement.

I approve the PR so that we can have test coverage on gNSI feature.

morrowc
morrowc reviewed Jan 20, 2024
View reviewed changes
feature/security/gnsi/certz/tests/client_certificates/client_certificates_test.go Outdated Show resolved Hide resolved
feature/security/gnsi/certz/tests/client_certificates/client_certificates_test.go Outdated Show resolved Hide resolved
feature/security/gnsi/certz/tests/client_certificates/client_certificates_test.go Outdated Show resolved Hide resolved
feature/security/gnsi/certz/tests/client_certificates/client_certificates_test.go Outdated Show resolved Hide resolved
feature/security/gnsi/certz/tests/client_certificates/client_certificates_test.go Outdated Show resolved Hide resolved
feature/security/gnsi/certz/tests/client_certificates/client_certificates_test.go Outdated Show resolved Hide resolved
feature/security/gnsi/certz/tests/client_certificates/client_certificates_test.go Outdated Show resolved Hide resolved
feature/security/gnsi/certz/tests/client_certificates/client_certificates_test.go Outdated Show resolved Hide resolved
feature/security/gnsi/certz/tests/client_certificates/client_certificates_test.go Outdated Show resolved Hide resolved
feature/security/gnsi/certz/tests/client_certificates/client_certificates_test.go Outdated Show resolved Hide resolved
@priyacj priyacj mentioned this pull request Feb 14, 2024
Closed
@priyacj priyacj closed this Feb 15, 2024
@priyacj priyacj reopened this Feb 15, 2024
morrowc
morrowc reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@morrowc morrowc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the static-analysis bits here.

@priyacj priyacj requested a review from a team as a code owner January 6, 2025 22:25
@priyacj priyacj closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcCharlebois MarcCharlebois MarcCharlebois left review comments

@morrowc morrowc morrowc left review comments

@LimeHat LimeHat LimeHat requested changes

@sezhang2 sezhang2 sezhang2 left review comments

@mihirpitale-googler mihirpitale-googler Awaiting requested review from mihirpitale-googler

Assignees

@mihirpitale-googler mihirpitale-googler

Labels
juniper-pr new-requirement-pr The PR introduces a new test scenario/requirement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gNSI] certz-1.1
9 participants
@priyacj @OpenConfigBot @coveralls @LimeHat @morrowc @sezhang2 @MarcCharlebois @mohanasm @mihirpitale-googler